Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename azurerm_graph_account to azurerm_graph_services_account #22665

Merged
merged 5 commits into from
Aug 7, 2023
Merged

rename azurerm_graph_account to azurerm_graph_services_account #22665

merged 5 commits into from
Aug 7, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Jul 25, 2023

There is request from service team that the resource should be called graph_services_account.

katbyte
katbyte requested changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change as is?, we cannot just rename the resource and break users who may be using it. you will need to alias the resources and deprecate the old ones to be removed in 4.0

@teowa
Copy link
Contributor Author

teowa commented Jul 27, 2023

this is a breaking change as is?, we cannot just rename the resource and break users who may be using it. you will need to alias the resources and deprecate the old ones to be removed in 4.0

The old one is still usable before 4.0, I have also add a test for this.

@teowa
Copy link
Contributor Author

teowa commented Jul 27, 2023 

--- PASS: TestAccGraphAccount (711.63s)
    --- PASS: TestAccGraphAccount/legacyAccount (143.91s)
        --- PASS: TestAccGraphAccount/legacyAccount/basic (143.91s)
    --- PASS: TestAccGraphAccount/account (567.73s)
        --- PASS: TestAccGraphAccount/account/basic (83.13s)
        --- PASS: TestAccGraphAccount/account/update (205.09s)
        --- PASS: TestAccGraphAccount/account/complete (140.44s)
        --- PASS: TestAccGraphAccount/account/requiresImport (139.06s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/graphservices 711.668s

@github-actions github-actions bot added size/L and removed size/M labels Jul 27, 2023
@teowa
Copy link
Contributor Author

teowa commented Aug 3, 2023

Hi team, can we merge this earlier for few customer has started using the resource.

stephybun
stephybun approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa LGTM 🎉

@stephybun stephybun merged commit 918c247 into hashicorp:main Aug 7, 2023
@github-actions github-actions bot added this to the v3.69.0 milestone Aug 7, 2023
stephybun added a commit that referenced this pull request Aug 7, 2023
@stephybun
Update for #22597 #22665 #22811 #22814 #22832 #22844
5f2d336
@teowa teowa mentioned this pull request Mar 25, 2024
Merged
14 tasks
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte requested changes

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation service/graph size/L
Projects
None yet
Milestone
v3.69.0
Development

Successfully merging this pull request may close these issues.
3 participants
@teowa @katbyte @stephybun